✨ Identify interesting Jars to decomp and improve decomp performance #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
force-pushed
the
decompileImprovements
branch
3 times, most recently
from
1876afe to
4457481
Compare
Signed-off-by: David Zager <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
decompileImprovements
branch
from
4457481 to
d3a4f11
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
decompileImprovements
branch
from
eba1e54 to
76bbe7a
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: David Zager <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
decompileImprovements
branch
2 times, most recently
from
f62c3f7 to
d4b5a1d
Compare
Signed-off-by: David Zager <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
decompileImprovements
branch
from
d4b5a1d to
d29438e
Compare
djzager
approved these changes
Oct 6, 2023
pranavgaikwad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
Fixes #319
Summary of changes:
When decompiling binaries, for every JAR we find, we attempt to look at its metadata to get artifact and group. If we dont find metadata, we look it up on maven central using its sha. For all such JARs that we find accurate information about, we add them to java project's pom as dependencies. For all other JARs, we send them to decompile.
In decompile, we are running concurrently. Also, instead of decompiling each class file individually, we are now decompiling whole JAR using fernflower and then exploding it (this is faster than individual .class file decompile)
Prior to initing Java provider, we are now downloading sources for all dependencies. If we find any that don't have sources, we are passing them to decompile.
When getting dependencies for a binary, we are now using same logic from step 1 to get more fine grained info for a JAR.